Repository navigation
Update rubyboy to 1.7.1 and drop its workarounds - #551
Merged
Merged
Conversation
rubyboy 1.7.0 provides Rubyboy::Rom::DEFAULT_PATH, reads the ROM in binary mode and makes its APU duty tables shareable, so the benchmark no longer needs to find the ROM through $", patch File.open on Windows or call make_shareable. Use the released gem instead of the git repository. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rubyboy 1.7.0 fixed the problems this benchmark worked around, so this updates it to the latest release, 1.7.1, from RubyGems and removes the workarounds:
Rubyboy::Rom::DEFAULT_PATHreplaces the lookup through$".File.binread, so theFile.openpatch from Fix benchmarks that fail on Windows #545 is no longer needed. @hsbt, this is the rubyboy fix you mentioned sending upstream; it is already in 1.7.0.make_shareablecalls are gone.The Gemfile now uses the released gem instead of the git repository. In the lockfile only rubyboy changes; ffi and Bundler stay at 1.17.2 and 4.0.12. rubyboy 1.7 requires Ruby 4.0 or later.
The emulator changed between 1.5.1 and 1.7.1 (fixes in MBC1 and the APU), so the timings shift. On an Apple M4 with Ruby 4.0.7 (
WARMUP_ITRS=5 MIN_BENCH_ITRS=10 MIN_BENCH_TIME=0):Tested with the default, YJIT and Ractor harnesses. I could not test on Windows.
🤖 Generated with Claude Code